New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shield and board definitions for M60 #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A few thoughts/comments, and a few fixes needed.
efbcfd5
to
c80de7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question/likely change for the keymap, and a few confirmations needed for the header tweaks. If those authors aren't readily available, I would suggest reverting just those couple changes, so we don't block merging this.
}; | ||
|
||
|
||
&flash0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I saw mention of additional flash on this? Not needed for the initial PR, but if it does have extra flash, we should get it defined at some point.
* Updated M60 keymap * Make nrfjproj as default runner * Remove the polling config
@petejohanson Addressed the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for adding these.
Shield and board definitions for M60
Shield and board definitions for M60
Added board and shield definition for M60 keyboard and makerdiary nrf52840 m.2 module
Tested all keys and working fine
https://imgur.com/a/Ry9HgvA