Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microdox Shield #245

Merged
merged 4 commits into from Oct 9, 2020
Merged

Conversation

careyk007
Copy link
Contributor

I haven't had a chance to fully vet the keymap, but I based it off of the Corne's default with some changes due to missing pinkie columns. I'm waiting on switches to fully populate my board, but all switch positions are registering correctly.

This was pleasantly straight forward to get working, thanks for the great documentation!

@innovaker innovaker added the shields PRs and issues related to shields label Oct 8, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new shield! A few miscellaneous comments and issues.

app/boards/shields/microdox/Kconfig.shield Outdated Show resolved Hide resolved
app/boards/shields/microdox/Kconfig.defconfig Show resolved Hide resolved
app/boards/shields/microdox/microdox.dtsi Outdated Show resolved Hide resolved
app/boards/shields/microdox/microdox.dtsi Outdated Show resolved Hide resolved
app/boards/shields/microdox/microdox.keymap Show resolved Hide resolved
app/boards/shields/microdox/microdox.keymap Show resolved Hide resolved
app/boards/shields/microdox/microdox_left.overlay Outdated Show resolved Hide resolved
app/boards/shields/microdox/microdox_right.overlay Outdated Show resolved Hide resolved
@careyk007
Copy link
Contributor Author

careyk007 commented Oct 9, 2020

@petejohanson Thanks for the review! I based all of these files on the corne shield (copied the folder and renamed everything microdox, then edited what needed tweaking). I'd be happy to make the changes you suggested here for the corne as well.

app/boards/shields/microdox/microdox_left.overlay Outdated Show resolved Hide resolved
app/boards/shields/microdox/microdox_right.overlay Outdated Show resolved Hide resolved
@careyk007
Copy link
Contributor Author

Huh, I have no idea why changing the license would cause building the bluemicro iris_right shield to fail

@petejohanson
Copy link
Contributor

@careyk007 The compiler segfaulted in that run... That definitely wasn't your doing. Re-running.

@petejohanson petejohanson added the enhancement New feature or request label Oct 9, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@petejohanson petejohanson merged commit 05af21a into zmkfirmware:main Oct 9, 2020
1 check passed
@careyk007 careyk007 deleted the microdox-shield branch October 11, 2020 00:27
MangoIV pushed a commit to MangoIV/zmk that referenced this pull request Dec 18, 2020
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants