New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial nullbitsco tidbit bring up #424
Conversation
Should I squash this PR's commits ahead of review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for this shield. I have a few cursory comments, and then there's a few files that need additions as well.
.github/workflows/build.yml
: Add tidbit to the shield list.
docs/docs/hardware.md
: You should add the tidbit to this list.
docs/static/setup.ps1
and docs/static/setup.sh
: tidbit should be added as a non-split option for both files.
Added and updates pushed for review |
I missed adding the tidbit_19key setup to the build / setup files. The changes/updates should be pushed shortly |
This may be problematic given the URL and variable assumptions present in the setup scripts. Maybe leave it out for the moment as it looks like some pretty big assumptions made by the setup scripts will break? |
2127a16
to
55b9d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
35fffe4
to
53f7913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor suggestions, but I went the extra mile because you've been giving a lot back to the project.
Should the tidbit_19key
be in the setup scripts?
Thanks @mcrosson!
It can't be in the setup scripts due to the file path assumptions those scripts have when pulling together the data from the main sources. I have that on my list of things to look at in the future if/when more boards start providing >1 default keymap. |
53f7913
to
8b853f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
23083ad
to
4ce5a2c
Compare
4ce5a2c
to
0bc8b02
Compare
Bring up for the nullbits.co tidbit. This bring up includes 2 keymaps that match the assembly documentation