Show layer label in display widget. #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
changed the title
petejohanson
force-pushed
the
display/highest-layer-label-display
branch
from
9f3de7b
to
d444029
Compare
|
Tested on the left half of my lily58, and it's working well. Might want some documentation on labels for keymaps. Also we should add label props to existing keymaps. |
Yeah, both were going to be follow up PRs. Any concerns @Nicell ? |
As long as they're planned for future PRs, I have no concerns. Code looks fine as far as I can tell 👍 |
petejohanson
force-pushed
the
display/highest-layer-label-display
branch
from
d444029
to
fab2cd5
Compare
petejohanson
force-pushed
the
display/highest-layer-label-display
branch
from
fab2cd5
to
7baeeb4
Compare
This was referenced Jan 4, 2021
MrMarble
pushed a commit
to MrMarble/zmk-viewer
that referenced
this pull request
Jan 9, 2024
Add support for an optional label property in layers which can match zero or once. In ZMK each layer can be assigned a display-name. One use case for the label is that it can be shown in display widgets. See zmkfirmware/zmk#551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.