Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Board: BDN9 Rev2 macropad #557

Merged
merged 2 commits into from Dec 31, 2020
Merged

New Board: BDN9 Rev2 macropad #557

merged 2 commits into from Dec 31, 2020

Conversation

petejohanson
Copy link
Contributor

  • Onboard stm32f072.
  • 3 possible encoder positions.
  • Underglow/per-key not yet support.

@petejohanson petejohanson added board PRs and issues related to boards. enhancement New feature or request labels Dec 30, 2020
Nicell
Nicell requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few small things!

app/include/zmk/sensors.h Outdated
#define ZMK_KEYMAP_HAS_SENSORS DT_NODE_EXISTS(ZMK_KEYMAP_SENSORS_NODE)
#define ZMK_KEYMAP_HAS_SENSORS DT_NODE_HAS_STATUS(ZMK_KEYMAP_SENSORS_NODE, okay)
#define ZMK_KEYMAP_SENSORS_LEN DT_PROP_LEN(ZMK_KEYMAP_SENSORS_NODE, sensors)
#define ZMK_KEYMAP_SENSORS_BY_IDX(idx) DT_PHANDLE_BY_IDX(ZMK_KEYMAP_SENSORS_NODE, sensors, idx) No newline at end of file
#define ZMK_KEYMAP_SENSORS_BY_IDX(idx) DT_PHANDLE_BY_IDX(ZMK_KEYMAP_SENSORS_NODE, sensors, idx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change meant to slip into this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did this as a small extra commit. It allows you to define the sensor node in the DT, empty so that user keymaps can just reference it, enable it, and set the list of sensors they want to use.

See the sample bdn9_rev2.keymap commented section near the top. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I think this makes sense. Might want a similar thing to be done on the tidbit.

app/boards/arm/bdn9/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/arm/bdn9/bdn9_rev2.keymap Show resolved Hide resolved
@petejohanson petejohanson enabled auto-merge (rebase) December 31, 2020 16:48
@innovaker
Copy link
Member

innovaker commented Dec 31, 2020 •
edited

Presumably this hasn't been added to setup.sh and setup.ps1 because they don't support shield-less boards yet?

@petejohanson
Copy link
Contributor Author

Presumably this hasn't been added to setup.sh and setup.ps1 because they don't support shield-less boards yet?

Correct. Given the efforts to move to a web based setup, I didn't want to invest the time to add that there just for this board.

@innovaker
Copy link
Member

The only other item missing from our usual checklist is a rudimentary README.md. See other boards/shields for examples. Are you skipping it for this PR?

@petejohanson
feat(boards): Add BDN9 Rev2 board.
4c9648a 
* Onboard stm32f072.
* 3 possible encoder positions.
* Underglow/per-key not yet support.
@petejohanson
Copy link
Contributor Author

Added the README.md.

@innovaker
Copy link
Member

This looks fine on the face of it. @Nicell, please could you check your review status given the subsequent force-pushes. If it's fine with you then I'll rubber stamp it.

@petejohanson petejohanson merged commit 3949055 into zmkfirmware:main Dec 31, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicell Nicell Nicell approved these changes

@innovaker innovaker innovaker approved these changes

Assignees

@Nicell Nicell

@innovaker innovaker

Labels
board PRs and issues related to boards. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petejohanson @innovaker @Nicell