Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial RGB Underglow implementation #64

Merged
merged 6 commits into from Jul 27, 2020

Conversation

Nicell
Copy link
Member

@Nicell Nicell commented Jul 25, 2020

Example usage can be found here: https://github.com/Nicell/zmk-config

Looking forward to comments on where I can improve my implementation.

@Nicell Nicell requested a review from petejohanson Jul 25, 2020
@Nicell Nicell added core Core functionality/behavior of ZMK behaviors enhancement New feature or request labels Jul 25, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

Great first work on this! A few comments.

app/CMakeLists.txt Show resolved Hide resolved

if ZMK_RGB_UNDERGLOW

config ZMK_RGB_UNDERGLOW_HUE_STEP
Copy link
Contributor

@petejohanson petejohanson Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

app/dts/behaviors/rgb_underglow.dtsi Outdated Show resolved Hide resolved
app/include/zmk/rgb_underglow.h Show resolved Hide resolved
app/src/behaviors/behavior_rgb_underglow.c Outdated Show resolved Hide resolved
app/include/zmk/rgb_underglow.h Outdated Show resolved Hide resolved
app/src/rgb_underglow.c Outdated Show resolved Hide resolved
app/src/rgb_underglow.c Outdated Show resolved Hide resolved
switch (state.current_effect)
{
case UNDERGLOW_EFFECT_SOLID:
zmk_rgb_underglow_effect_solid();
Copy link
Contributor

@petejohanson petejohanson Jul 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps future thought... but for size sake later, we should probably make each effect be enabled/disabled via Kconfig setting.

app/src/rgb_underglow.c Outdated Show resolved Hide resolved
@Nicell Nicell marked this pull request as ready for review Jul 25, 2020
@Nicell Nicell requested a review from petejohanson Jul 25, 2020
Copy link
Contributor

@petejohanson petejohanson left a comment

One more item I missed the first go-round. Otherwise looks good!

app/src/rgb_underglow.c Show resolved Hide resolved
Copy link
Contributor

@petejohanson petejohanson left a comment

Great work!

@petejohanson petejohanson merged commit 4e5a819 into zmkfirmware:main Jul 27, 2020
1 check passed
MangoIV referenced this pull request in MangoIV/zmk Dec 18, 2020
Initial RGB Underglow implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behaviors core Core functionality/behavior of ZMK enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants