Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splitreus62 shield #92

Merged
merged 12 commits into from Aug 22, 2020
Merged

Conversation

Na-Cly
Copy link
Contributor

@Na-Cly Na-Cly commented Aug 15, 2020

No description provided.

app/boards/shields/splitreus62/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/shields/splitreus62/splitreus62.conf Outdated Show resolved Hide resolved
app/boards/shields/splitreus62/splitreus62_right.overlay Outdated Show resolved Hide resolved
app/boards/shields/splitreus62/splitreus62_left.overlay Outdated Show resolved Hide resolved
Copy link
Contributor

@petejohanson petejohanson left a comment

Just a few minor things here and there. Thanks!

@@ -0,0 +1,8 @@
# Copyright (c) 2020 Pete Johanson
Copy link
Contributor

@petejohanson petejohanson Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not me!

@@ -0,0 +1,18 @@
/*
* Copyright (c) 2020 Pete Johanson
Copy link
Contributor

@petejohanson petejohanson Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace or update the copyright.

@@ -0,0 +1,22 @@
/*
* Copyright (c) 2020 Pete Johanson
Copy link
Contributor

@petejohanson petejohanson Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@@ -37,7 +37,7 @@ echo ""
echo "Keyboard Shield Selection:"

prompt="Pick an keyboard:"
options=("Kyria" "Lily58" "Corne")
options=("Kyria" "Lily58" "Corne" "Splitreus62")
Copy link
Contributor

@petejohanson petejohanson Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added properly in the select below.

@petejohanson petejohanson merged commit 760de7d into zmkfirmware:main Aug 22, 2020
1 check passed
MangoIV referenced this pull request in MangoIV/zmk Dec 18, 2020
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants