Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
...
  • 4 commits
  • 6 files changed
  • 0 commit comments
  • 2 contributors
Showing with 43 additions and 5 deletions.
  1. +11 −1 README.md
  2. +8 −0 coffee/site.coffee
  3. +9 −2 coffee/views.coffee
  4. +1 −1 index.html
  5. +11 −0 js/site.js
  6. +3 −1 js/views.js
View
@@ -5,4 +5,14 @@ This is a result of a random idea "What would my github events look like in a ti
This is still rough, so there are bugs. Unfortunately I can only pull down 10 pages of events from Github. I'm going to tinker with http://www.githubarchive.org/ to see if I may be able to get more from that instead.
-Oh and the design is hideous. I'd welcome any designers to submit a better design and I'd integrate it.
+Oh and the design is hideous. I'd welcome any designers to submit a design and I'd gladly integrate it.
+
+TODO
+--------
+
+* Finish the views for all events
+* Fix odd masonry behavior where all the events shift to the left
+* Better filtering logic (Combine a few items. Not everything is filterable)
+* Relate new repo events with repo list. Renaming repos results in broken links.
+* Consolidate Push events for a single day. There's need to display one block per event.
+* Perhaps wack the site with an ugly stick of hot pink. That may motivate a designer that's currently on the fence :)
View
@@ -77,6 +77,7 @@ class Event extends Spine.Model
when "PushEvent"
if @payload.commits?.length > 0 then "push" else "skip"
when "DeleteEvent" then "skip"
+ when "WatchEvent" then "watch"
else "item"
viewInfo: ->
@@ -150,6 +151,13 @@ class Event extends Spine.Model
gravatar:@payload.target.avatar_url
date:@created_at_short_string()
]
+ when "watch"
+ [view,
+ id:@id
+ repo:@repo.name
+ repo_url:"https://github.com/#{@repo.name}"
+ date:@created_at_short_string()
+ ]
when "repository"
[view,
id:@id
View
@@ -25,7 +25,6 @@ views["index"] = """
</div>
"""
-
views["show"] = """
<header class="page-header well row">
<div class="span1 offset3"><img src="{{user.avatar_url}}" alt="image of {{user.name}}"/></div>
@@ -106,8 +105,16 @@ views["repository"] = """
</li>
"""
+views["watch"] = """
+<li class="item" data-id="{{id}}" data-type="branch">
+ <span class="corner"></span>
+ <h1>Began watching <a href="{{repo_url}}">{{repo}}</a></h1>
+ <span class="date">{{date}}</span>
+</li>
+"""
+
views["branch"] = """
-<li class="item hidden" data-id="{{id}}" data-type="branch">
+<li class="item" data-id="{{id}}" data-type="branch">
<span class="corner"></span>
<h1>Branched <a href="{{url}}">{{name}}</a> from <a href="{{repo_url}}">{{repo}}</a></h1>
<span class="date">{{date}}</span>
View
@@ -29,6 +29,6 @@
<script src="js-lib/spine/route.js" type="text/javascript"></script>
<script src="js-lib/mustache.js" type="text/javascript"></script>
<script src="js/views.js" type="text/javascript"></script>
- <script src="js/site.js?2" type="text/javascript"></script>
+ <script src="js/site.js?3" type="text/javascript"></script>
</body>
</html>
View

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.
View

Some generated files are not rendered by default. Learn more.

Oops, something went wrong.

No commit comments for this range