New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes windows EOL #5

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@yanick
Contributor

yanick commented Mar 23, 2016

Simply removed the \r's at the end of the Makefile in the pdf2json tarball.

Fixes #1

@zmughal

This comment has been minimized.

Show comment
Hide comment
@zmughal

zmughal Apr 11, 2016

Member

Hi, thanks for the patch!

It took me a while to get a FreeBSD system up and running to try this out. There seem to be some problems with the patch, but you're on the right track. Patching the Makefile is fine, but really, the Makefile.in should be corrected since ./configure will generate that.

I'll put together another commit to do that in a few.

Member

zmughal commented Apr 11, 2016

Hi, thanks for the patch!

It took me a while to get a FreeBSD system up and running to try this out. There seem to be some problems with the patch, but you're on the right track. Patching the Makefile is fine, but really, the Makefile.in should be corrected since ./configure will generate that.

I'll put together another commit to do that in a few.

zmughal added a commit that referenced this pull request Apr 12, 2016

Patch the source package
- Convert the `Makefile.in` to Unix line endings.
- Remove the `Makefile.in` variable assignment which forces the C++
  compiler to `g++`.

Both of these settings cause issues on systems that have non-GNU build
toolchains such as *BSD.

Thanks to YANICK and SREZIC for reporting the problems and providing
solutions.

Closes:
  - <#5>
  - <#3>
  - <https://rt.cpan.org/Public/Bug/Display.html?id=94985>

@zmughal zmughal self-assigned this Apr 12, 2016

@zmughal zmughal added the in progress label Apr 12, 2016

@zmughal zmughal closed this in #6 Apr 12, 2016

@zmughal zmughal removed the in progress label Apr 12, 2016

@zmughal

This comment has been minimized.

Show comment
Hide comment
@zmughal

zmughal Apr 12, 2016

Member

Patch incorporated into #6 and merged. New version will hit CPAN in a few!

Thank you again!

Member

zmughal commented Apr 12, 2016

Patch incorporated into #6 and merged. New version will hit CPAN in a few!

Thank you again!

@zmughal zmughal referenced this pull request Apr 12, 2016

Closed

look at FreeBSD build issue #3

@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Apr 14, 2016

Contributor

Woohoo! And it's all mah pleasure. :-)

Contributor

yanick commented Apr 14, 2016

Woohoo! And it's all mah pleasure. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment