SubstituteAndReturn: Faster search for contextual s///r, y///r#2
Merged
Conversation
This uses `each_match_of(Expression)` instead of `each_match_within(Expression)` because `each_match_within()` is only able to find one instance of a contextual substitution or transliteration on each pass because the inner matches did not specify the entire pattern for what an expression can contain.
…ions This reduces the calls to `match_positions_of()` which helps skip most expressions which will not have a `s///` or `y///` in them.
The positions should already be sorted.
zmughal
force-pushed
the
s-and-r-optim
branch
from
2c911a6 to
a79cbe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s///r,y///rPerformance
Before
After