Please sign in to comment.
Fix logging in with PASS after USER
First, we set m_sUser to the argument of USER. Later, when the PASS came in, the username which was specified here (user/network:pass) was ignored, because m_sUser was already set ("if (m_sUser.empty() &&" in ParseAuthLine). The fix is to ignore if m_sUser was already set when parsing "PASS". Since this means that the handling of PASS and USER becomes even more different, this commit removes CClient::ParseAuthLine() again. (The check for m_sUser.empty() can't just be dropped, because if USER comes in after PASS, we should use the user name from PASS and ignore the USER one) Signed-off-by: Uli Schlachter <firstname.lastname@example.org>
- Loading branch information...