Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Revert "Add 381 to the buffer (You are now an IRC Operator)"

This reverts commit 11e5f76.

Having this in the raw buffer multiple times is obviously wrong, because you can
use /oper more than once and would get a new 381 numeric each time. So this
would need to use UpdateRawBuffer() instead of AddRawBuffer() (=replace old
entries with the same text).

However, this is still wrong. If you -o yourself, you no longer have oper
status. ZNC wouldn't notice this and still deliver the 381 numeric to new
clients.

Clients which use raw 381 to detect oper status will have to switch to user mode
+o.

Thanks to Han` for reporting this problem.
  • Loading branch information...
commit 999cc085d2906879bbe634ef3af472cde2d5a0d0 1 parent 588e478
@psychon psychon authored
Showing with 0 additions and 3 deletions.
  1. +0 −3  src/IRCSock.cpp
View
3  src/IRCSock.cpp
@@ -420,9 +420,6 @@ void CIRCSock::ReadLine(const CString& sData) {
break;
}
- case 381: // You are now an IRC Operator
- m_pNetwork->AddRawBuffer(":" + _NAMEDFMT(sServer) + " " + sCmd + " {target} " + _NAMEDFMT(sRest));
- break;
case 375: // begin motd
case 422: // MOTD File is missing
if (m_pNetwork->GetIRCServer().Equals(sServer)) {
Please sign in to comment.
Something went wrong with that request. Please try again.