Skip to content
Browse files

Warn if a *module message is ignored

Some modules (e.g. webadmin) don't handle messages to *module in any way. Make
it clear to the user why they didn't get any reply back in this case.

Signed-off-by: Uli Schlachter <>
  • Loading branch information...
1 parent 55ba59d commit eb229659e53764a7d288c4561523f3907b9cf8d8 @psychon psychon committed May 13, 2011
Showing with 6 additions and 1 deletion.
  1. +6 −1 Modules.cpp
7 Modules.cpp
@@ -493,7 +493,12 @@ void CModule::OnModCommand(const CString& sCommand) {
void CModule::OnUnknownModCommand(const CString& sLine) {
- if (!m_mCommands.empty())
+ if (m_mCommands.empty())
+ // This function is only called if OnModCommand wasn't
+ // overriden, so no false warnings for modules which don't use
+ // CModCommand for command handling.
+ PutModule("This module doesn't implement any commands.");
+ else
PutModule("Unknown command!");

0 comments on commit eb22965

Please sign in to comment.
Something went wrong with that request. Please try again.