New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server passwords are printed during startup #1599

Open
dwfreed opened this Issue Sep 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@dwfreed

dwfreed commented Sep 27, 2018

e.g.:

$ znc
[ .. ] Checking for list of available modules...
[ .. ] Opening config [/home/dwfreed/.znc/configs/znc.conf]...
[ .. ] Loading global module [webadmin]...
[ .. ] Binding to port [+6697] on host [::1]...
[ .. ] Binding to port [+6697] on host [127.0.0.1]...
[ ** ] Loading user [dwfreed]
[ ** ] Loading network [NETWORK]
[ .. ] Adding server [::1 +31459 PASSWORD]...
[ .. ] Loading user module [chansaver]...
[ .. ] Loading user module [controlpanel]...
[ .. ] Loading user module [buffextras]...
[ .. ] Forking into the background...
[ >> ] [pid: 9127]
[ ** ] ZNC 1.7.1 - https://znc.in

This is from:

CUtils::PrintAction("Adding server [" + sServer + "]");

This is an issue because ZNC's startup messages could end up somewhere less secure than ZNC's config file, without realizing it, eg syslog, journal, email, depending on how ZNC is started. ZNC already doesn't send the server password during ListServers as of 1.7.0, so the same should be applied to startup messages.

Zarthus added a commit to Zarthus/znc that referenced this issue Oct 12, 2018

Zarthus added a commit to Zarthus/znc that referenced this issue Oct 14, 2018

fix: znc#1599 - Server passwords are printed during startup
(by only displaying the number of servers added)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment