Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sasl: Make the first requirement for SET actually mandatory, return i… #1338

Merged
merged 1 commit into from Nov 12, 2016

Conversation

@Zarthus
Copy link
Contributor

commented Nov 5, 2016

…nformation about settings if no input for SET

This changes SASL to have the first parameter of set actually be required, by responding with information about the current configuration when no parameters are passed.

I come across it from time to time where I try to look up my info, and with /msg *sasl set I accidentally overwrite my existing settings. Oops!


Now returns the following message:

Username is currently set to 'Zarthus', a password was supplied.
…nformation about settings if no input for SET
@DarthGandalf DarthGandalf merged commit 881fa94 into znc:master Nov 12, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.1%) to 41.019%
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jlu5

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2017

To extend upon this, it would be even better if this behaviour was actually mentioned in /msg *sasl help. A status command with similar output could also make this more user friendly.

Zarthus added a commit to Zarthus/znc that referenced this pull request Jan 5, 2017
With znc#1338, the parameter username was made optional, but the help
was not changed to reflect this.

ref. znc#1338 (comment)
@Zarthus

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2017

@GLolol

Thanks for pointing that out, I've made another PR to update this.

DarthGandalf added a commit that referenced this pull request Jan 12, 2017
With #1338, the parameter username was made optional, but the help
was not changed to reflect this.

ref. #1338 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.