Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Webskin "znc-ation" #155

Merged
merged 5 commits into from Apr 10, 2012

Conversation

Projects
None yet
3 participants
Contributor

jakoch commented Mar 28, 2012

Thanks for creating such a great bouncer. This is my contribution to the ZNC project to give something back.

I was satisfied with the features ZNC has, that's why i installed it.
But i was not satisfied with the provided Webskin (or as i call them Themes) for administration.
I know it was hardcoded some time ago. So i tried to enhance the default theme a bit.
Well, as always, its a matter of taste.
I also implemented some requests from your side, because of dislikes of certain things in the webskin.

Plesae note that there are some minor glitches in the skin, mainly due to the fact, that i used some workarounds for positioning things, because i didn't want to mess up the other skins by modifying their templates.

This pull request is squashed to a single commit, because i do not want to mess up your log with my ultra-incremental commit log. I will also contribute my notes about skining/templating to the wiki. They contain a list of expressions useable on client-side and may be helpful for the next templating guy to come.

You own your corner of the web. Also you know your files better than me. In 5 days i was able to get a small glimpse of the project. Thanks for all your help in fiddling around with the C source. I would kindly ask you to add missing variables, when you integrate this pull request.

Best regards, Jens

@psychon psychon commented on an outdated diff Mar 28, 2012

modules/chansaver.cpp
@@ -76,7 +76,6 @@ class CChanSaverMod : public CModule {
template<> void TModInfo<CChanSaverMod>(CModInfo& Info) {
Info.SetWikiPage("chansaver");
- Info.AddType(CModInfo::NetworkModule);
@psychon

psychon Mar 28, 2012

Owner

Uhm, what? Why?

@psychon psychon commented on the diff Mar 28, 2012

webskins/znc-ation/LICENSE.nuvola
@@ -0,0 +1,35 @@
+The Theme "ZNC-ATION" for "ZNC - Advanced IRC Bouncer"
+uses icons from the Nuvola Icons Set by David Vignoni (http://icon-king.com).
+
+Nuvola Icons Set License - GNU LGPL v2.1 and v3
@psychon

psychon Mar 28, 2012

Owner

This refers to two licenses but neither of these license is given anywhere. I guess this would need us to ship the full license text.

Also GPLv3 is incompatible to GPLv2 and thus can't be used with znc: http://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility
So that means znc has to use the LGPL v2.1 version

Owner

psychon commented Mar 28, 2012

I guess that chansaver change wasn't intentional and should be removed and if anyone wants to merge this, I'll happen to look in another direction and miss the license stuff.

@DarthGandalf DarthGandalf merged commit 84d9377 into znc:master Apr 10, 2012

Owner

DarthGandalf commented Apr 10, 2012

Merged only changes to the core. The skin itself doesn't work well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment