Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adminlog.cpp #1557

Closed
wants to merge 1 commit into from

Conversation

@csprr
Copy link
Contributor

csprr commented Jun 14, 2018

Change GetParamsColon(1) to (0), as (1) does not show the error message, it will show an empty [] in the adminlog

Change GetParamsColon(1) to (0), as (1) does not show the error message, it will show an empty [] in the adminlog
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #1557 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   37.49%   37.52%   +0.03%     
==========================================
  Files         126      126              
  Lines       30962    30973      +11     
  Branches       93       93              
==========================================
+ Hits        11608    11624      +16     
+ Misses      19305    19300       -5     
  Partials       49       49
Impacted Files Coverage Δ
modules/adminlog.cpp 2.25% <0%> (ø) ⬆️
src/Translation.cpp 67.03% <0%> (-1.94%) ⬇️
include/znc/Csocket.h 62.09% <0%> (-0.66%) ⬇️
src/FileUtils.cpp 49.75% <0%> (-0.5%) ⬇️
src/znc.cpp 49.22% <0%> (-0.04%) ⬇️
modules/webadmin.cpp 7.26% <0%> (-0.01%) ⬇️
src/Utils.cpp 68.81% <0%> (+2.2%) ⬆️
include/znc/version.h 90% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed6cb7...6fbfdff. Read the comment docs.

@DarthGandalf

This comment has been minimized.

Copy link
Member

DarthGandalf commented Jun 14, 2018

Thanks, applied to 1.7 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.