New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule 'docker' to latest master. #1608

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Zarthus
Contributor

Zarthus commented Oct 13, 2018

Uses znc 1.7.1 for local docker, avoiding the exploits 1.7.0 has

@DarthGandalf

This comment has been minimized.

Member

DarthGandalf commented Oct 13, 2018

This has no effect. The submodule is used only in https://github.com/znc/znc/blob/master/Dockerfile#L52-L53

@Zarthus

This comment has been minimized.

Contributor

Zarthus commented Oct 14, 2018

Huh, that's interesting.

Is there a reason that file is completely separated? Is znc shipping 3 Dockerfiles?

Why not just let the /Dockerfile utilize /docker/slim/.../Dockerfile?

@DarthGandalf

This comment has been minimized.

Member

DarthGandalf commented Oct 14, 2018

If you have an idea how to reduce duplication, please say.
The Dockerfile(s) in znc-docker repo downloads the tarball to build the release version (https://hub.docker.com/_/znc/), while Dockerfile in znc repo builds from local source, resulting in e.g. https://hub.docker.com/r/zncbouncer/znc-git/tags/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment