Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Remove partyline #1651

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Zarthus
Copy link
Contributor

commented Apr 12, 2019

Fixes #1632

There may be some additional considerations left, I spotted a

third_party/Csocket/examples/ChatServer.cc:                     WriteAll( "[" + m_sName + "] Has joined the partyline.\n" );

but the core idea gets across. I may look into additional cleanup (if necessary) around next Hacktoberfest.

@Zarthus Zarthus force-pushed the Zarthus:remove_partyline branch from d5e25be to 7121706 Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #1651 into master will increase coverage by 0.55%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
+ Coverage   37.23%   37.79%   +0.55%     
==========================================
  Files         127      126       -1     
  Lines       31045    30601     -444     
  Branches       93       93              
==========================================
+ Hits        11561    11566       +5     
+ Misses      19435    18986     -449     
  Partials       49       49
Impacted Files Coverage Δ
src/IRCNetwork.cpp 66.48% <0%> (-0.97%) ⬇️
src/FileUtils.cpp 49.39% <0%> (-0.49%) ⬇️
include/znc/Csocket.h 50.33% <0%> (+0.67%) ⬆️
src/Utils.cpp 67.9% <0%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0370efe...c817b3d. Read the comment docs.

@Zarthus Zarthus force-pushed the Zarthus:remove_partyline branch 2 times, most recently from 2e2817b to d94605c Apr 12, 2019

Show resolved Hide resolved src/IRCNetwork.cpp Outdated

@Zarthus Zarthus force-pushed the Zarthus:remove_partyline branch 3 times, most recently from 488b54f to 8cffd5a Apr 20, 2019

Show resolved Hide resolved src/IRCNetwork.cpp Outdated

@Zarthus Zarthus referenced this pull request Apr 20, 2019

Open

modules: Remove Q #1653

@Zarthus Zarthus force-pushed the Zarthus:remove_partyline branch 2 times, most recently from 92e9c02 to d9d85bf Apr 20, 2019

modules: Remove partyline
Fixes #1632
Closes #1301 as wontfix
Closes #1058 as wontfix
Closes #386 as wontfix
Closes #362 as wontfix
Closes #302 as wontfix

@Zarthus Zarthus force-pushed the Zarthus:remove_partyline branch from d9d85bf to c817b3d Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.