Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename global IntersectionObserver object #1

Closed
manniL opened this issue Jan 18, 2019 · 1 comment
Closed

Rename global IntersectionObserver object #1

manniL opened this issue Jan 18, 2019 · 1 comment

Comments

@manniL
Copy link

@manniL manniL commented Jan 18, 2019

Hey 馃憢

You might want to rename window.io to something that's less common or prefix it somehow 鈽猴笍

if (isBrowser) window.io = io;

@znck

This comment has been minimized.

Copy link
Owner

@znck znck commented Jan 18, 2019

That was not supposed to be there. Forgot to remove.

@znck znck closed this in 8cf3aa7 Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can鈥檛 perform that action at this time.