Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SearchInArchive parameter not used in the fulltext search of the toolbar. #479

Merged
merged 9 commits into from Dec 1, 2023

Conversation

tipue-dev
Copy link
Contributor

@tipue-dev tipue-dev commented Aug 16, 2023

Proposed change

SearchInArchive search parameter isn't used in the toolbar search anymore, because the block 'ToolBarSearchFulltext' has been removed and the condition to check if the parameter should be added didn't get any Data anymore.

Additionally, the test (Selenium/Output/ToolBar/TicketSearchFulltext.t) failed because of this, and because the search menu had to be opened to select fulltext-search.

1 - 🐞 bug 🐞

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified. labels Aug 23, 2023
Kernel/Output/HTML/Layout.pm Outdated Show resolved Hide resolved
@dennykorsukewitz dennykorsukewitz changed the title Fixed SearchInArchive parameter not used in the fulltext search of the toolbar Fixed SearchInArchive parameter not used in the fulltext search of the toolbar. Sep 26, 2023
@dennykorsukewitz dennykorsukewitz self-assigned this Sep 26, 2023
@NiklasSchmitt NiklasSchmitt added the 3 - wait for merge Znuny, it's your turn. label Nov 6, 2023
@NiklasSchmitt NiklasSchmitt merged commit 35b422d into znuny:dev Dec 1, 2023
12 of 14 checks passed
@NiklasSchmitt NiklasSchmitt removed their assignment Dec 1, 2023
@NiklasSchmitt NiklasSchmitt removed the 3 - wait for merge Znuny, it's your turn. label Dec 1, 2023
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_14 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants