Skip to content

Fixed SearchInArchive parameter not used in the fulltext search of the toolbar. - #479

Merged
NiklasSchmitt merged 9 commits into
znuny:devfrom
tipue-dev:dev-ticket_search_fulltext
Dec 1, 2023
Merged

NiklasSchmitt merged 9 commits into
znuny:devfrom
tipue-dev:dev-ticket_search_fulltext

Conversation

@tipue-dev

@tipue-dev tipue-dev commented Aug 16, 2023 •

Copy link
Copy Markdown
Contributor

Proposed change

SearchInArchive search parameter isn't used in the toolbar search anymore, because the block 'ToolBarSearchFulltext' has been removed and the condition to check if the parameter should be added didn't get any Data anymore.

Additionally, the test (Selenium/Output/ToolBar/TicketSearchFulltext.t) failed because of this, and because the search menu had to be opened to select fulltext-search.

1 - 🐞 bug 🐞

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@rkaldung rkaldung added 1 - 🐞 bug 🐞 An issue with the system. 3 - verified This issue or pull request was verified. labels Aug 23, 2023
Comment thread Kernel/Output/HTML/Layout.pm
@dennykorsukewitz dennykorsukewitz changed the title Fixed SearchInArchive parameter not used in the fulltext search of the toolbar Fixed SearchInArchive parameter not used in the fulltext search of the toolbar. Sep 26, 2023
@dennykorsukewitz dennykorsukewitz self-assigned this Sep 26, 2023
Comment thread Kernel/Output/HTML/Layout.pm
@NiklasSchmitt NiklasSchmitt added the 2 - wait for merge Znuny, it's your turn. label Nov 6, 2023
@NiklasSchmitt
NiklasSchmitt merged commit 35b422d into znuny:dev Dec 1, 2023
@NiklasSchmitt NiklasSchmitt removed their assignment Dec 1, 2023
@NiklasSchmitt NiklasSchmitt removed the 2 - wait for merge Znuny, it's your turn. label Dec 1, 2023
@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_14 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 - 🐞 bug 🐞 An issue with the system. 3 - verified This issue or pull request was verified.

Development

Successfully merging this pull request may close these issues.

4 participants