New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-native-push-notification Appears to be a git repo or submodule. #1057
Comments
Same here, I need to delete the package from my node_modules folder on the preinstall hook in order to make npm install work |
Deleting the .git folder on react-native-push-notification and npm install afterwards makes it work. |
Yes, but why does this happen in the first place? |
This is something new with npm 6.9 i think |
remove any .git files present in the node_modules folder In your terminal, from your project folder: |
Yeah. This was definitely bothering me as well. I agree that it seems like it shouldn't be happening in the first place? |
@zo0r This is a bug in this package. The ".git" directly should not be included in the npm package. |
@zo0r is this going to be fixed anytime soon? I'm getting tired of not being able to do |
I believe this is a problem with NPM (npm/npm#20213) |
This only happens in latest version, |
Would love to see a fix for this! @zo0r Please update the npm package 😆 |
As a temporary fix we added the following to our
This will probably not work on Windows but a similar solution on Windows can be applied. |
@mlazari I have the same problem with |
@SergeyIsakhanyan Did you remove node_modules folder before downgrading to |
@isaiahols I'm looking at other dependencies we use that don't have this issue and they also don't have
react-native doesn't even seem to have a That could solve the issue, but it's probably not the only issue. |
@mlazari you are absolutely correct this is an not issue. The issue is that the npmignore is supposed to include the . git by default but it is not. So the current working solution while that is being sorted is to just include it manually. Then when the fix is up there is still no issue with including it in your npmignore as it is there by default. Just something to help in the meantime as this only seems to effect a few dependencies, this one included. |
Is there a valid reason for having a .git folder in the node_modules dir? |
No. You should never have anything under version control down there because changes you make will never be saved between installs. |
This PR will fix this issue. https://github.com/zo0r/react-native-push-notification/pull/1085 |
This helped me.Thanks |
Worked! |
Any update on this? Still happening half a year later. |
i have install react-native-push-notification and react-native link react-native-push-notification
but when i want to install another package or run npm install i face with this error
The text was updated successfully, but these errors were encountered: