Drop vestigial thread safety support. #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelStorage is IMVCCStorage, meaning each Connection has its own object, and Connections aren't thread safe.
This already only did anything on top-level instances anyway. There doesn't seem to be a good reason for that anymore.
There's one test from ZODB,
BasicStorage.BasicStorage.check_checkCurrentSerialInTransaction
which attempts to interleave operations on a storage from multiple threads. It's prepared to cope with some race conditions, though not all: it still depends on some implicit locking within the object. We workaround this by giving it what it wants.