Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sourcemaps in dynamic-imports #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rebane2001
Copy link

At the moment, it is possible to read the client sourcemap files like this:

fetch("http://localhost/__meteor__/dynamic-import/fetch", {
  "body": JSON.stringify({"imports":{"index.js.map":1}}),
  "method": "POST",
  "mode": "cors",
}).then(e => e.text()).then(console.log)

This is due to the meteor/dynamic-import package accessing the filesystem directly, as opposed to using staticFiles.

I mitigated it by adding a handler to Meteor that destroys the response when an invalid request is received. It is a pretty hacky solution, but it's the best I could come up with and it seems to work great, feel free to suggest a better one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant