Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the length attribute of enclosure tag - Podcast feed #72

Merged
merged 1 commit into from Feb 25, 2015
Merged

Fix the length attribute of enclosure tag - Podcast feed #72

merged 1 commit into from Feb 25, 2015

Conversation

@philss
Copy link
Contributor

@philss philss commented Feb 21, 2015

It also adds the audio_file_length to the source files of posts.

The length attribute is the size in bytes of the audio file.

You can get this value using cURL. Example:

curl -I -L http://zofe.com.br/episodios/zofe-0-apresentacao

The "Content-Length" header is what we want. If the URL follow
redirects (which is the case of SoundCloud), you may need to take
the last value for the audio file length (which is the bigger number).

This issue is related to #68

It also adds the audio_file_length to the source files of posts

The length attribute is the size in bytes of the audio file.

You can get this value using cURL. Example:

    curl -I -L http://zofe.com.br/episodios/zofe-0-apresentacao

The "Content-Length" header is what we want. If the URL follow
redirects (which is the case of SoundCloud), you may need to take
the last value for the audio file length (which is the bigger number).
@philss
Copy link
Contributor Author

@philss philss commented Feb 21, 2015

In case you are wondering, this is the script used to fetch file lengths and update the posts.

@nltncsr
Copy link
Contributor

@nltncsr nltncsr commented Feb 21, 2015

Awesome!

@nltncsr
Copy link
Contributor

@nltncsr nltncsr commented Feb 21, 2015

All the podcast feeds that I'm inspecting work right in this way and... It worked for me too in the app!
(I'm testing only in the last entry, so we can see the differences clearly)

Lista de podcast, com o atributo length consertado

@caiogondim
Copy link
Member

@caiogondim caiogondim commented Feb 21, 2015

Uploaded the builded site to http://tmp.caiogondim.com
Can we double check if the issue was resolved for you?

@nltncsr
Copy link
Contributor

@nltncsr nltncsr commented Feb 22, 2015

Thanks for the testing area, @caiogondim !

For me worked perfectly.

@philss
Copy link
Contributor Author

@philss philss commented Feb 22, 2015

@caiogondim @niltoncms Thanks for the testing area.
It's ok for me as well! My Podcast app read the feed without problems.

👍

@caiogondim
Copy link
Member

@caiogondim caiogondim commented Feb 22, 2015

Thank you so much for figuring out the problem, guys.
Will wait @danielfilho to merge and deploy.

@danielfilho
Copy link
Contributor

@danielfilho danielfilho commented Feb 22, 2015

I'm at my home town but without a computer to deploy it.

tomorrow it will be in production.

thank guys. love you all :)

@philss
Copy link
Contributor Author

@philss philss commented Feb 25, 2015

@danielfilho \o/

I forgot to mention one thing: every new episode will require the audio_file_length attribute to be filled. This can be made as I described in this PR description.

We can create some kind of task to do that automatically if you think it's necessary.
Please let me know if there is something pending to get this merged.

@danielfilho
Copy link
Contributor

@danielfilho danielfilho commented Feb 25, 2015

I already set that on the 21st, @philss. you can check that here.

I just need to take ten minutes to check all changes. today I was a bit in a rush, so I think I can manage the merge tomorrow morning and then, :shipit: :D

thanks again!

danielfilho added a commit that referenced this pull request Feb 25, 2015
Fix the length attribute of enclosure tag - Podcast feed
@danielfilho danielfilho merged commit 61fdd36 into zofepod:master Feb 25, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@philss
Copy link
Contributor Author

@philss philss commented Feb 25, 2015

@danielfilho \o/ 😃

@philss philss deleted the philss:fix-podcast-feed/length-attribute branch Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants