New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Addressed github issue #1. #2

Merged
merged 1 commit into from Sep 24, 2016

Conversation

Projects
None yet
2 participants
@manwar
Contributor

manwar commented Sep 24, 2016

Hi @zoffixznet ,

As a part of PRC 2016, I propose the PR to address the GitHub issue #1 with regard to "Bad skip count".
Quick investigation reveals the "Bad skip count" only occurs when there is no access to internet. This
is how I dealt with it.

  • Split the test script t/00-load.t into two scripts (t/0-load.t and t/01-unit-test.t)

  • The test script (t/0-load.t) deals with simple loading modules, removed the extra "0" from the file name to force it to be the first script to run as the generated script t/00-compile.t was taking the precedence.

  • The other script (t/01-unit-test.t) actually does the real unit testing and only bother testing if the
    environment has access to internet. I am using Test::RequiresInternet for this.

    Many Thanks.

    Best Regards,
    Mohammad S Anwar

@zoffixznet zoffixznet merged commit acb054b into zoffixznet:master Sep 24, 2016

@zoffixznet

This comment has been minimized.

Show comment
Hide comment
@zoffixznet

zoffixznet Sep 24, 2016

Owner

Thanks a lot!

Owner

zoffixznet commented Sep 24, 2016

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment