New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet aliases #279

Closed
yegor256 opened this Issue Jun 22, 2018 · 15 comments

Comments

Projects
None yet
5 participants
@yegor256
Collaborator

yegor256 commented Jun 22, 2018

Let's make it possible to assign aliases to wallets. Let's create a file .zoldata/aliases with two columns: wallet ID and alias. The alias has to match /^[a-zA-Z0-9\-_]$/. To assign it:

$ zold alias set 17737fee5b825835 wts

Here, the wallet 17737fee5b825835 will get alias wts. To remove it:

$ zold alias remove 17737fee5b825835

To show current alias of a wallet:

$ zold alias show 17737fee5b825835
wts

Or just

$ zold alias 17737fee5b825835
There is no alias for the wallet 17737fee5b825835, you can set it with 'zold alias set'

If the alias is set, it must be possible to use it everywhere we use wallet ID. For example:

$ zold show wts
$ zold pay wts John 15 'Thanks, John!'
$ zold push wts

@0crat 0crat removed their assignment Jun 22, 2018

@0crat 0crat added the scope label Jun 22, 2018

@0crat

This comment has been minimized.

Collaborator

0crat commented Jun 22, 2018

Job #279 is now in scope, role is DEV

@0crat

This comment has been minimized.

Collaborator

0crat commented Jun 22, 2018

Bug was reported, see §29: +15 point(s) just awarded to @yegor256/z

@yegor256

This comment has been minimized.

Collaborator

yegor256 commented Jun 25, 2018

@0crat

This comment has been minimized.

Collaborator

0crat commented Jun 25, 2018

@0crat assign @botanicus (here)

@yegor256 The job #279 assigned to @botanicus/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat

This comment has been minimized.

Collaborator

0crat commented Jun 25, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

botanicus added a commit to botanicus/zold that referenced this issue Jun 30, 2018

Add skeleton for zold-io#279
# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Thu Jun 28 07:37:24 2018 +0200
#
# interactive rebase in progress; onto 2ad2653
# Last commands done (5 commands done):
#    squash c36164b Puzzles added
#    squash 7bbefd0 Uncomment the ruby directive
# Next commands to do (15 remaining commands):
#    pick 6fa5c53 Fix zold-io#113
#    pick e4a0b77 zold-io#300 logging documented
# You are currently rebasing branch 'issue-279' on '2ad2653'.
#
# Changes to be committed:
#	modified:   bin/zold
#	new file:   lib/zold/commands/alias.rb
#	new file:   test/commands/test_alias.rb
#

botanicus added a commit to botanicus/zold that referenced this issue Jun 30, 2018

@0crat

This comment has been minimized.

Collaborator

0crat commented Jun 30, 2018

@botanicus/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0pdd

This comment has been minimized.

Collaborator

0pdd commented Jul 2, 2018

@yegor256 2 puzzles #322, #323 are still not solved.

@botanicus

This comment has been minimized.

Contributor

botanicus commented Jul 2, 2018

@yegor256 please close this.

@yegor256

This comment has been minimized.

Collaborator

yegor256 commented Jul 2, 2018

@botanicus thanks!

@yegor256 yegor256 closed this Jul 2, 2018

@0crat

This comment has been minimized.

Collaborator

0crat commented Jul 2, 2018

@ypshenychka/z please review this job completed by @botanicus/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jul 2, 2018

@0crat

This comment has been minimized.

Collaborator

0crat commented Jul 2, 2018

The job #279 is now out of scope

@ypshenychka

This comment has been minimized.

ypshenychka commented Jul 3, 2018

@0crat quality good

@0crat

This comment has been minimized.

Collaborator

0crat commented Jul 3, 2018

Order was finished, quality is "good": +38 point(s) just awarded to @botanicus/z

@0crat

This comment has been minimized.

Collaborator

0crat commented Jul 3, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd

This comment has been minimized.

Collaborator

0pdd commented Jul 11, 2018

@yegor256 4 puzzles #323, #377, #378, #379 are still not solved; solved: #322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment