New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store capitalized words in a separate array #6

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Projects
None yet
2 participants
@dabrorius
Contributor

dabrorius commented Aug 6, 2015

  • This way sentences will always start with capitalized words
  • No need to randomly pick multiple times and hope for the best
Store capitalized words in separate array.
- This way sentances will always start with capitalized words
- No need to randomly pick multiple times and hope for the best
@zolrath

This comment has been minimized.

Show comment
Hide comment
@zolrath

zolrath Aug 6, 2015

Owner

Definitely a sensible optimization! Can you include a test that adds a few mock sentences and ensures that capitalized_words contains the proper wordlist?

Thanks!

Owner

zolrath commented Aug 6, 2015

Definitely a sensible optimization! Can you include a test that adds a few mock sentences and ensures that capitalized_words contains the proper wordlist?

Thanks!

@dabrorius

This comment has been minimized.

Show comment
Hide comment
@dabrorius

dabrorius Aug 6, 2015

Contributor

Sure, I'll try to get it done over the weekend.

Contributor

dabrorius commented Aug 6, 2015

Sure, I'll try to get it done over the weekend.

@zolrath

This comment has been minimized.

Show comment
Hide comment
@zolrath

zolrath Aug 24, 2015

Owner

If you'd like to add the tests in a separate pull request that would be great but I'll add them soon if you don't!
Hope you have fun making your own library, this one was originally made to generate terrible jokes from existing jokes.

Owner

zolrath commented Aug 24, 2015

If you'd like to add the tests in a separate pull request that would be great but I'll add them soon if you don't!
Hope you have fun making your own library, this one was originally made to generate terrible jokes from existing jokes.

zolrath added a commit that referenced this pull request Aug 24, 2015

Merge pull request #6 from dabrorius/master
Store capitalized words in a separate array

@zolrath zolrath merged commit 15fb962 into zolrath:master Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment