Store capitalized words in a separate array #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dabrorius
commented
Aug 6, 2015
dabrorius
commented
- This way sentences will always start with capitalized words
- No need to randomly pick multiple times and hope for the best
- This way sentances will always start with capitalized words - No need to randomly pick multiple times and hope for the best
|
Definitely a sensible optimization! Can you include a test that adds a few mock sentences and ensures that capitalized_words contains the proper wordlist? Thanks! |
|
Sure, I'll try to get it done over the weekend. |
|
If you'd like to add the tests in a separate pull request that would be great but I'll add them soon if you don't! |
zolrath
added a commit
that referenced
this pull request
Aug 24, 2015
Store capitalized words in a separate array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.