Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscelaneous #3

Merged
merged 6 commits into from Mar 21, 2019
Merged

Miscelaneous #3

merged 6 commits into from Mar 21, 2019

Conversation

tladesignz
Copy link

  • Fixed some UI Issues with iPhone X/XS... (bottom edge was not filled)
  • Fixed a new incompatibility with Keanu (changed method name)
  • Fixed CocoaPods warning
  • Use constants from Config.xcconfig instead of hardcoded values in project config.

Sorry, the last one sets signing to "manual". But that's easy to fix: You just need to add the name of the certificates in Config.xcconfig like this:

PROVISIONING_PROFILE_MAIN_DEV =
PROVISIONING_PROFILE_SPECIFIER_MAIN_DEV = Keanu Dev
PROVISIONING_PROFILE_MAIN_RELEASE =
PROVISIONING_PROFILE_SPECIFIER_MAIN_RELEASE = Keanu Dist

PROVISIONING_PROFILE_SHARE_EXTENSION_DEV =
PROVISIONING_PROFILE_SPECIFIER_SHARE_EXTENSION_DEV = Keanu ShareExtension Dev
PROVISIONING_PROFILE_SHARE_EXTENSION_RELEASE =
PROVISIONING_PROFILE_SPECIFIER_SHARE_EXTENSION_RELEASE = Keanu ShareExtension Dist

If Xcode can't find the certs, go to "Preferences..." -> "Accounts" -> "Download Manual Profiles" or press "Download Profile..." in the "Provisioning Profile" dropdown.

After that, build should work again as expected.

But if you do this, every contributor can easily reconfigure for themselves to run on their own hardware device.

Copy link
Collaborator

@N-Pex N-Pex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@N-Pex N-Pex merged commit 4583a9b into zom:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants