fix(cargo-pgx): on init, lazy fetch version list #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| default_pgx | ||
| for (pgver, pg_config_path) in versions { | ||
| let config = if pg_config_path == "download" { | ||
| if default_pgx.is_none() { |
There was a problem hiding this comment.
Wanna do .get_or_insert() here instead?
There was a problem hiding this comment.
I initially did that too! However it ends up leaving the code more complicated, since you need to deal with the error from Pgx::default(...)?.
There was a problem hiding this comment.
Of course. LGTM as-is.
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
force-pushed
the
cargo-pgx-init-lazy
branch
from
87fba1e
to
f7d3f3d
Compare
Hoverbear
added a commit
that referenced
this pull request
May 1, 2021
`pgx` v0.1.21 is a minor feature release with the following features: * aarch64 support was added (#127) * add Nix flake (#124) * `cargo-pgx pgx init` does `initdb` (#123) * Improve handling of feature flags (#118) * Allow overriding function names and returning schema-qualified type (#117) * update dependencies (#122). * (docs) Add caveat about reconnecting after updating extension (#116) There were the following fixes: * (`cargo-pgx`) on init, lazy fetch version list (#119) To upgrade, please run: ``` $ cargo install cargo-pgx --version 0.1.21 ``` Also, make sure to update your Cargo.toml dependencies. Signed-off-by: Ana Hobden <operator@hoverbear.org>
Merged
Hoverbear
added a commit
that referenced
this pull request
May 1, 2021
`pgx` v0.1.21 is a minor feature release with the following features: * aarch64 support was added (#127) * add Nix flake (#124) * `cargo-pgx pgx init` does `initdb` (#123) * Improve handling of feature flags (#118) * Allow overriding function names and returning schema-qualified type (#117) * update dependencies (#122). * (docs) Add caveat about reconnecting after updating extension (#116) There were the following fixes: * (`cargo-pgx`) on init, lazy fetch version list (#119) To upgrade, please run: ``` $ cargo install cargo-pgx --version 0.1.21 ``` Also, make sure to update your Cargo.toml dependencies. Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on https://github.com/Hoverbear/pgx/tree/nix-flake, I determined that
cargo-pgx pgx initwould reach to network even if passed allpg_configversions it might want.This patch defers the network call to fetch versions until it actually needs to be done.
This means a call like
Won't necessarily reach for network.