Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract principal not displayed properly on Ledger screen #141

Closed
MarvinJanssen opened this issue Dec 14, 2022 · 4 comments
Closed

Contract principal not displayed properly on Ledger screen #141

MarvinJanssen opened this issue Dec 14, 2022 · 4 comments
Assignees
@neithanmo

Comments

@MarvinJanssen
Copy link

MarvinJanssen commented Dec 14, 2022 •
edited by zboto bot
Loading

Related to #121 but I do not think it was fixed in that PR.

When a contract principal is passed as a contract call argument, the transaction is signed properly. However, the contract name part of the principal is not shown on the display which can be used to mislead the user.

I did not take a photo but the contract name part is simply dropped using the latest Stacks applet installed via Ledger Live.

Thus SP1RYXGJP8R1CCMTDHJJQSP93ECDKPP9A0YWYZTGZ.some-contract is displayed simply as SP1RYXGJP8R1CCMTDHJJQSP93ECDKPP9A0YWYZTGZ

🔗 zboto Link
@neithanmo neithanmo self-assigned this Feb 16, 2023
@neithanmo
Copy link
Collaborator

neithanmo commented Feb 16, 2023 •
edited by zboto bot
Loading

Thanks for the report, I will address this. So the idea is to append the contract name after the address instead of dedicating a screen page for it.

@neithanmo
Copy link
Collaborator

neithanmo commented Feb 23, 2023 •
edited by zboto bot
Loading

@MarvinJanssen
I wonder if the contract name has to be displayed as well for a PostConditionPrincipal in the case it is a ContractPrincipal.

@neithanmo neithanmo mentioned this issue Feb 24, 2023
Merged
@neithanmo
Copy link
Collaborator

neithanmo commented Feb 27, 2023 •
edited by zboto bot
Loading

closed via #147
changes would be included in the next review in order to be released.

@MarvinJanssen
Copy link
Author

MarvinJanssen commented Feb 27, 2023 •
edited by zboto bot
Loading

@neithanmo yes definitely. It should be displayed everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neithanmo neithanmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarvinJanssen @neithanmo