New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fails for the backend (Debian 8) with the following results: #337

Closed
sandoche2k opened this Issue Dec 20, 2017 · 11 comments

Comments

Projects
None yet
5 participants
@sandoche2k
Contributor

sandoche2k commented Dec 20, 2017

cp lib/Zonemaster/Backend/Translator.pm blib/lib/Zonemaster/Backend/Translator.pm
cp lib/Zonemaster/Backend/Config.pm blib/lib/Zonemaster/Backend/Config.pm
cp lib/Zonemaster/Backend/DB/MySQL.pm blib/lib/Zonemaster/Backend/DB/MySQL.pm
cp lib/Zonemaster/Backend/DB/PostgreSQL.pm blib/lib/Zonemaster/Backend/DB/PostgreSQL.pm
cp lib/Zonemaster/Backend/TestAgent.pm blib/lib/Zonemaster/Backend/TestAgent.pm
cp lib/Zonemaster/Backend.pm blib/lib/Zonemaster/Backend.pm
cp lib/Zonemaster/Backend/DB.pm blib/lib/Zonemaster/Backend/DB.pm
cp lib/Zonemaster/Backend/DB/SQLite.pm blib/lib/Zonemaster/Backend/DB/SQLite.pm
cp lib/Zonemaster/Backend/RPCAPI.pm blib/lib/Zonemaster/Backend/RPCAPI.pm
cp script/zonemaster_backend_rpcapi.psgi blib/script/zonemaster_backend_rpcapi.psgi
/usr/bin/perl "-Iinc" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/zonemaster_backend_rpcapi.psgi
cp script/zonemaster_backend_testagent blib/script/zonemaster_backend_testagent
/usr/bin/perl "-Iinc" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/zonemaster_backend_testagent
sandoche@vps323914:~/zonemaster-backend$ make test
PERL_DL_NONLAZY=1 PERL_USE_UNSAFE_INC=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
t/test01.t ................ 3/? Can't locate object method "blessed" via package "External query for afnic.fr, NS attempted to ns1.nic.fr/2001:67c:2218:2::4:1 while running with no_network at /usr/local/share/perl/5.20.2/Zonemaster/Engine/Test/Basic.pm line 276.
" (perhaps you forgot to load "External query for afnic.fr, NS attempted to ns1.nic.fr/2001:67c:2218:2::4:1 while running with no_network at /usr/local/share/perl/5.20.2/Zonemaster/Engine/Test/Basic.pm line 276.
"?) at /home/sandoche/zonemaster-backend/blib/lib/Zonemaster/Backend/TestAgent.pm line 156.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 9.
t/test01.t ................ Dubious, test returned 2 (wstat 512, 0x200)
All 9 subtests passed 
t/test_validate_syntax.t .. ok    

Test Summary Report
-------------------
t/test01.t              (Wstat: 512 Tests: 9 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=2, Tests=36,  2 wallclock secs ( 0.03 usr  0.01 sys +  2.52 cusr  0.10 csys =  2.66 CPU)
Result: FAIL
Failed 1/2 test programs. 0/36 subtests failed.
Makefile:794: recipe for target 'test_dynamic' failed
make: *** [test_dynamic] Error 255

@sandoche2k sandoche2k added this to the 2017.4 milestone Dec 20, 2017

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 20, 2017

Contributor

When I have installed Zonemaster::LDNS from develop branch and Zonemster::Engine from develop branch I get the same error as @sandoche2k.

When switch Zonemaster::Engine to latest release from CPAN (but keeping Zonemaster::LDNS) I do not get any error:

$ make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
t/test01.t ................ ok    
t/test_validate_syntax.t .. ok    
All tests successful.
Files=2, Tests=54,  7 wallclock secs ( 0.03 usr  0.00 sys +  6.81 cusr  0.12 csys =  6.96 CPU)
Result: PASS

@vlevigneron, can you look at this issue?

Contributor

matsduf commented Dec 20, 2017

When I have installed Zonemaster::LDNS from develop branch and Zonemster::Engine from develop branch I get the same error as @sandoche2k.

When switch Zonemaster::Engine to latest release from CPAN (but keeping Zonemaster::LDNS) I do not get any error:

$ make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
t/test01.t ................ ok    
t/test_validate_syntax.t .. ok    
All tests successful.
Files=2, Tests=54,  7 wallclock secs ( 0.03 usr  0.00 sys +  6.81 cusr  0.12 csys =  6.96 CPU)
Result: PASS

@vlevigneron, can you look at this issue?

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Dec 20, 2017

Contributor

I could get around this problem by doing two things:

  1. Adding use Scalar::Util qw( blessed ) to Zonemaster::Backend::TestAgent.
  2. Running ZONEMASTER_RECORD=1 perl -Ilib t/test01.t

I don't know why the old data used to play nice but doesn't anymore. I don't know why Travis didn't catch this either.

Contributor

mattias-p commented Dec 20, 2017

I could get around this problem by doing two things:

  1. Adding use Scalar::Util qw( blessed ) to Zonemaster::Backend::TestAgent.
  2. Running ZONEMASTER_RECORD=1 perl -Ilib t/test01.t

I don't know why the old data used to play nice but doesn't anymore. I don't know why Travis didn't catch this either.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 20, 2017

Contributor

@mattias-p, what is the difference between your fix and @vlevigneron's patch?

Contributor

matsduf commented Dec 20, 2017

@mattias-p, what is the difference between your fix and @vlevigneron's patch?

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Dec 20, 2017

Contributor

@matsduf #339 doesn't import blessed. Also I haven't tried to compare the recorded data but I guess those could have minor differences.

Contributor

mattias-p commented Dec 20, 2017

@matsduf #339 doesn't import blessed. Also I haven't tried to compare the recorded data but I guess those could have minor differences.

@vlevigneron

This comment has been minimized.

Show comment
Hide comment
@vlevigneron

vlevigneron Dec 21, 2017

Contributor

@matsduf no difference, I have just re-created a new data file. You can use your patch @mattias-p

Contributor

vlevigneron commented Dec 21, 2017

@matsduf no difference, I have just re-created a new data file. You can use your patch @mattias-p

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 21, 2017

Contributor

@vlevigneron and @mattias-p! Do you understand why the data file works with the current version of the Engine but not with the upcoming?

Contributor

matsduf commented Dec 21, 2017

@vlevigneron and @mattias-p! Do you understand why the data file works with the current version of the Engine but not with the upcoming?

@vlevigneron

This comment has been minimized.

Show comment
Hide comment
@vlevigneron

vlevigneron Dec 21, 2017

Contributor

@matsduf I have not look in depth but data file is closely linked with LDNS, so if something has changed in LDNS, it may have impacts on the content of data file.

Contributor

vlevigneron commented Dec 21, 2017

@matsduf I have not look in depth but data file is closely linked with LDNS, so if something has changed in LDNS, it may have impacts on the content of data file.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 21, 2017

Contributor

@vlevigneron! It seems to be a change in Engine that cause the problem.

  • Updated LDNS + Updated Engine + Updated Backend (without fix) => It breaks.
  • Updated LDNS + Current Engine + Updated Backend (without fix) => It works.

It is unsatisfactory if we do not understand the underlying problem.

Contributor

matsduf commented Dec 21, 2017

@vlevigneron! It seems to be a change in Engine that cause the problem.

  • Updated LDNS + Updated Engine + Updated Backend (without fix) => It breaks.
  • Updated LDNS + Current Engine + Updated Backend (without fix) => It works.

It is unsatisfactory if we do not understand the underlying problem.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Jan 2, 2018

Contributor

@vlevigneron! The problem is introduced by the following commit in zonemaster-engine. When I reset to that commit, the Backend test breaks:

commit 378c41398f80ea045b3425ebe7ef2f80ecca1b59
Author: vlevigneron <vincent.levigneron@nic.fr>
Date:   Thu Dec 7 15:54:23 2017 +0100

    - fixes dotse/zonemaster-engine#295

When I reset to the commit below, it works:

commit 871fff74e13e8efc9f0897ee5a08fa1bbd0fe02f
Merge: ca1dfd1 9f587ab
Author: vlevigneron <vincent.levigneron@nic.fr>
Date:   Mon Nov 27 09:41:19 2017 +0000

    Merge pull request #346 from vlevigneron/issue-zonemaster-engine-296
    
    closes dotse/zonemaster-engine#296

I only reinstalled Engine. Everything else was equal. The following files were updated with by the commit:

lib/Zonemaster/Engine.pm
lib/Zonemaster/Engine/Recursor.pm
lib/Zonemaster/Engine/Test/Basic.pm
share/en.po
share/fr.po
share/sv.po
Contributor

matsduf commented Jan 2, 2018

@vlevigneron! The problem is introduced by the following commit in zonemaster-engine. When I reset to that commit, the Backend test breaks:

commit 378c41398f80ea045b3425ebe7ef2f80ecca1b59
Author: vlevigneron <vincent.levigneron@nic.fr>
Date:   Thu Dec 7 15:54:23 2017 +0100

    - fixes dotse/zonemaster-engine#295

When I reset to the commit below, it works:

commit 871fff74e13e8efc9f0897ee5a08fa1bbd0fe02f
Merge: ca1dfd1 9f587ab
Author: vlevigneron <vincent.levigneron@nic.fr>
Date:   Mon Nov 27 09:41:19 2017 +0000

    Merge pull request #346 from vlevigneron/issue-zonemaster-engine-296
    
    closes dotse/zonemaster-engine#296

I only reinstalled Engine. Everything else was equal. The following files were updated with by the commit:

lib/Zonemaster/Engine.pm
lib/Zonemaster/Engine/Recursor.pm
lib/Zonemaster/Engine/Test/Basic.pm
share/en.po
share/fr.po
share/sv.po
@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Jan 3, 2018

Contributor

Closed by #342 @vlevigneron ?

Contributor

sandoche2k commented Jan 3, 2018

Closed by #342 @vlevigneron ?

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Jan 3, 2018

Contributor

PR #342 solves this issue.

Contributor

matsduf commented Jan 3, 2018

PR #342 solves this issue.

@matsduf matsduf closed this Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment