New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 292 #324

Merged
merged 4 commits into from Jan 5, 2018

Conversation

Projects
None yet
4 participants
@mtoma
Contributor

mtoma commented Dec 14, 2017

Fix issue #292

@mtoma mtoma requested review from mattias-p and matsduf Dec 14, 2017

@mattias-p

Looks good to me, except indentation.

Show outdated Hide outdated lib/Zonemaster/Backend/DB/PostgreSQL.pm
Show outdated Hide outdated lib/Zonemaster/Backend/TestAgent.pm
Show outdated Hide outdated script/create_db_mysql.pl

@sandoche2k sandoche2k added this to the 2017.4 milestone Dec 19, 2017

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Dec 21, 2017

Contributor

@mtoma please merge after resolving the conflicts.

Contributor

sandoche2k commented Dec 21, 2017

@mtoma please merge after resolving the conflicts.

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Dec 21, 2017

Contributor

Please clean up the commits and the commit messages using git rebase -i so only the relevant issue numbers are mentioned.

Contributor

mattias-p commented Dec 21, 2017

Please clean up the commits and the commit messages using git rebase -i so only the relevant issue numbers are mentioned.

@mtoma mtoma dismissed stale reviews from matsduf and mattias-p via b074c3f Jan 2, 2018

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Jan 3, 2018

Contributor

@mtoma Is this PR supposed to update TestAgent.pm?

Contributor

mattias-p commented Jan 3, 2018

@mtoma Is this PR supposed to update TestAgent.pm?

@mattias-p

I really appreciate you separating indentation changes to a separate commit. That makes reviewing much easier!

Show outdated Hide outdated lib/Zonemaster/Backend/DB/PostgreSQL.pm
@matsduf

matsduf approved these changes Jan 4, 2018

@mtoma mtoma merged commit 799f4e6 into zonemaster:develop Jan 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment