New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 287 #325

Merged
merged 3 commits into from Dec 21, 2017

Conversation

Projects
None yet
4 participants
@mtoma
Contributor

mtoma commented Dec 14, 2017

No description provided.

mattias-p and others added some commits Nov 2, 2017

Merge pull request #311 from dotse/develop
Merge 2.0.0 to master

@mtoma mtoma requested review from mattias-p and matsduf Dec 14, 2017

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Dec 15, 2017

Contributor

So what is required for approving the PR? An update to the API documentation?

Contributor

mattias-p commented Dec 15, 2017

So what is required for approving the PR? An update to the API documentation?

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 15, 2017

Contributor

@mattias-p, I think we should see this update as a "bug" because the API dcumentation should state that domain must not be empty. I think that a comment with code plus an issue that this should be corrected as soon as the current GUI is phased out.

Contributor

matsduf commented Dec 15, 2017

@mattias-p, I think we should see this update as a "bug" because the API dcumentation should state that domain must not be empty. I think that a comment with code plus an issue that this should be corrected as soon as the current GUI is phased out.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 19, 2017

Contributor

An issue #333 has been created to remove the work-around.

Contributor

matsduf commented Dec 19, 2017

An issue #333 has been created to remove the work-around.

@sandoche2k sandoche2k added this to the 2017.4 milestone Dec 19, 2017

@sandoche2k sandoche2k merged commit 8cbd0cc into zonemaster:develop Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Dec 21, 2017

Contributor

@mtoma merging, since we have consensus

Contributor

sandoche2k commented Dec 21, 2017

@mtoma merging, since we have consensus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment