New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid known filenames in world-writable directory #359

Merged
merged 3 commits into from Jan 12, 2018

Conversation

Projects
None yet
4 participants
@mattias-p
Contributor

mattias-p commented Jan 12, 2018

Fixes #358.

This also includes a drive-by simplification of a neighbouring line.

I've successfully tested the Debian instruction.

@sandoche2k Would you test the CentOS instruction? I'll start doing it myself as well, but I have a hunch that you'll be able to make it quicker.

@mattias-p mattias-p requested review from pawal, matsduf and sandoche2k Jan 12, 2018

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Jan 12, 2018

Contributor
Contributor

sandoche2k commented Jan 12, 2018

@mattias-p mattias-p referenced this pull request Jan 12, 2018

Merged

Adapt to debian 7 #356

@matsduf

@mattias-p, do you expect to have this included in v2017.4?

Show outdated Hide outdated docs/Installation.md Outdated
@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Jan 12, 2018

Contributor

I've tested this on CentOS. The changes in this PR worked fine, but I had a few unrelated hick-ups.

Debian 7:

  • zm-backend.sh status command gives no output

CentOS 7:

  • Engine CPAN dependencies installation failed - I did manage to install all the dependencies separately by splitting up the cpan command
  • A unit test failed for Zonemaster::LDNS: In t/wireformat.t the TLSA test
  • The mysql command prompts for a password
  • zm-centos.sh status command gives no output

As such I believe this PR should be merged for 2017.4. We should also consider whether the above hick-ups are serious enough to block this release.

Contributor

mattias-p commented Jan 12, 2018

I've tested this on CentOS. The changes in this PR worked fine, but I had a few unrelated hick-ups.

Debian 7:

  • zm-backend.sh status command gives no output

CentOS 7:

  • Engine CPAN dependencies installation failed - I did manage to install all the dependencies separately by splitting up the cpan command
  • A unit test failed for Zonemaster::LDNS: In t/wireformat.t the TLSA test
  • The mysql command prompts for a password
  • zm-centos.sh status command gives no output

As such I believe this PR should be merged for 2017.4. We should also consider whether the above hick-ups are serious enough to block this release.

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Jan 12, 2018

Contributor

Moved the hick-ups discussion to #360.

@matsduf Please re-review this PR.

Contributor

mattias-p commented Jan 12, 2018

Moved the hick-ups discussion to #360.

@matsduf Please re-review this PR.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Jan 12, 2018

Contributor

@mattias-p, I am running installation of Backend as part of reviewing.

Contributor

matsduf commented Jan 12, 2018

@mattias-p, I am running installation of Backend as part of reviewing.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Jan 12, 2018

Contributor

@mattias-p, please merge.

Contributor

matsduf commented Jan 12, 2018

@mattias-p, please merge.

@mattias-p mattias-p merged commit 014dc3e into zonemaster:develop Jan 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mattias-p mattias-p deleted the mattias-p:356-secure-ipc branch Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment