New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Danish translation. #62

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@matsduf
Contributor

matsduf commented Dec 6, 2017

This is the first step to solve issue #61. The actual translation must be added to this PR.

@matsduf matsduf requested a review from sandoche2k Dec 6, 2017

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 6, 2017

Contributor

@haarbo! More files need translation to Danish. Can you provide the translation in the da.po file in this PR? You could provide it as a PR against the "translation-danish" branch on "matsduf/zonemaster-cli".

Contributor

matsduf commented Dec 6, 2017

@haarbo! More files need translation to Danish. Can you provide the translation in the da.po file in this PR? You could provide it as a PR against the "translation-danish" branch on "matsduf/zonemaster-cli".

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Dec 12, 2017

Contributor

@matsduf with #61, we will have Danish translation. Ok to merge.

Contributor

sandoche2k commented Dec 12, 2017

@matsduf with #61, we will have Danish translation. Ok to merge.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 12, 2017

Contributor

@sandoche2k, should we merge this now, or should we wait for @haarbo to provide the real translation?

Contributor

matsduf commented Dec 12, 2017

@sandoche2k, should we merge this now, or should we wait for @haarbo to provide the real translation?

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Dec 12, 2017

Contributor

@matsduf as per the issue explanation, i think we should merge. For Danish translation, there is #61?

Contributor

sandoche2k commented Dec 12, 2017

@matsduf as per the issue explanation, i think we should merge. For Danish translation, there is #61?

@matsduf matsduf merged commit e5f8ccb into zonemaster:develop Dec 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matsduf matsduf deleted the matsduf:translation-danish branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment