Join GitHub today
Fake delegation with explicit IP address is ignored #295
I have this scenario:
Notice that one name server is not responding. Now suppose this name server is actually going to be made available on a different IP address, and I want to test this before changing the name's address, and I do:
Now, the engine is ignoring the IP address that has been explicitly passed in, so I can't do a pre-delegation test of that specific IP address.
The engine ignores addresses of out-of-zone name servers in fake delegations. If a name server is provided with an IP address then that address should be used, and no recursive lookup should be done on that name server name. If only one address type is provided (IPv4, IPv6), then the other shoud not be looked up.
added a commit
Dec 7, 2017
@sandoche2k, we do not approve commits, we approve PRs. That commit is included in PR #355 which @mattias-p and I have reviewed with requests for updates. That PR is also strongly connected to PR zonemaster/zonemaster-cli#63 which I have reviewed thoroughly. I have even installed the code from both PRs and tested different scenarios. Based on that I have given some comments in zonemaster/zonemaster-cli#63.