New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a truly unused address for the tests #225

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@yanick

yanick commented Aug 18, 2016

Fixes #219

@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Sep 20, 2016

Contributor

Thank you for your pull request! I'm sorry it's been kept waiting so long.
It seems the test suite fails because Travis responds to ping in the entire range you're scanning. Not your fault, of course. However, I've proposed another solution in #219. If you want to update your PR to the new solution or join the discussion you're welcome.

Contributor

mattias-p commented Sep 20, 2016

Thank you for your pull request! I'm sorry it's been kept waiting so long.
It seems the test suite fails because Travis responds to ping in the entire range you're scanning. Not your fault, of course. However, I've proposed another solution in #219. If you want to update your PR to the new solution or join the discussion you're welcome.

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Nov 14, 2016

Contributor

@mattias-p i am closing.

Contributor

sandoche2k commented Nov 14, 2016

@mattias-p i am closing.

@sandoche2k sandoche2k closed this Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment