New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixes dotse/zonemaster-engine#275 #311

Merged
merged 4 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@vlevigneron
Contributor

vlevigneron commented Sep 12, 2017

  • First test with "develop" branch.
  • Needs translation for RECURSIVITY_UNDEF in swedish

@matsduf matsduf added this to the 2017.4 milestone Sep 27, 2017

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Nov 11, 2017

Contributor

@matsduf or @mattias-p can you check with the Swedish translation and approve the PR

Contributor

sandoche2k commented Nov 11, 2017

@matsduf or @mattias-p can you check with the Swedish translation and approve the PR

Show outdated Hide outdated lib/Zonemaster/Engine/Test/Nameserver.pm Outdated
Show outdated Hide outdated lib/Zonemaster/Engine/Test/Nameserver.pm Outdated
Show outdated Hide outdated share/sv.po Outdated
@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Nov 22, 2017

Contributor

@vlevigneron do you approve the review made by @matsduf and if so, thanks for updating the PR.

Contributor

sandoche2k commented Nov 22, 2017

@vlevigneron do you approve the review made by @matsduf and if so, thanks for updating the PR.

@vlevigneron

This comment has been minimized.

Show comment
Hide comment
@vlevigneron

vlevigneron Nov 25, 2017

Contributor

@matsduf OK for me, you can merge this PR.

Contributor

vlevigneron commented Nov 25, 2017

@matsduf OK for me, you can merge this PR.

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 7, 2017

Contributor

@vlevigneron, will you update this PR to meet my comments?

Contributor

matsduf commented Dec 7, 2017

@vlevigneron, will you update this PR to meet my comments?

@vlevigneron

This comment has been minimized.

Show comment
Hide comment
@vlevigneron

vlevigneron Dec 7, 2017

Contributor

@matsduf last commit should meet your requirements. Is it OK for you ?

Contributor

vlevigneron commented Dec 7, 2017

@matsduf last commit should meet your requirements. Is it OK for you ?

@matsduf

This comment has been minimized.

Show comment
Hide comment
@matsduf

matsduf Dec 7, 2017

Contributor

@vlevigneron, I suggest Cannot determine if the following servers are recursive nameservers or not: {names} instead of Can not determine recursivity of the following nameservers : {names} I think that is easier to understand. What do you think?

All po files must have the same msgid and the same as the message that we finalize on (above).

Contributor

matsduf commented Dec 7, 2017

@vlevigneron, I suggest Cannot determine if the following servers are recursive nameservers or not: {names} instead of Can not determine recursivity of the following nameservers : {names} I think that is easier to understand. What do you think?

All po files must have the same msgid and the same as the message that we finalize on (above).

@vlevigneron

This comment has been minimized.

Show comment
Hide comment
@vlevigneron

vlevigneron Dec 7, 2017

Contributor

Message modified. Please check swedish translation.

Contributor

vlevigneron commented Dec 7, 2017

Message modified. Please check swedish translation.

@matsduf

matsduf approved these changes Dec 7, 2017

@vlevigneron vlevigneron merged commit 52d73cf into zonemaster:develop Dec 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment