New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests in rr.t fail, make them less picky #26

Closed
matsduf opened this Issue Dec 5, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@matsduf
Contributor

matsduf commented Dec 5, 2017

Internet has changed again, so two unit tests fail and installation fails. A work-around is to ignore tests depending on Internet:

sudo TEST_NO_NETWORK=1 cpan -i Zonemaster::LDNS
  • For the DNSKEY test, require that at least one key is based on algorithm 8 (and accept other algorithms on other keys).
  • For the RRSIG test, expect key tag 59407 for at least one RRSIG, but accept other key tags for other.
  • Make "no network" default, and only run the tests that require Internet to be unchanged on demand, i.e. for release tests.
t/rr.t ............. 1/?     
    #   Failed test at t/rr.t line 106.
    #          got: '8'
    #     expected: '5'
    
    #   Failed test at t/rr.t line 106.
    #          got: '8'
    #     expected: '5'
    # Looks like you failed 2 tests of 16.

#   Failed test 'DNSKEY'
#   at t/rr.t line 109.
    
    #   Failed test at t/rr.t line 123.
    #          got: '59407'
    #     expected: '59747'
    # Looks like you failed 1 test of 32.

#   Failed test 'RRSIG'
#   at t/rr.t line 128.
# Looks like you failed 2 tests of 15.
t/rr.t ............. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/15 subtests 

matsduf added a commit to matsduf/zonemaster-ldns that referenced this issue Dec 6, 2017

Fixed so rr.t so it matches current Internet and changed so that test…
…s that depend on network are not run by default (issue zonemaster#26)

@matsduf matsduf referenced this issue Dec 6, 2017

Merged

Fixed issue #26 #27

matsduf added a commit that referenced this issue Dec 19, 2017

Fixed issue #26 (#27)
* Fixed so rr.t so it matches current Internet and changed so that tests that depend on network are not run by default (issue #26)
* .travis.yml is updated so that network tests are always run.
* Updated README.md to document the new solution.
@mattias-p

This comment has been minimized.

Show comment
Hide comment
@mattias-p

mattias-p Dec 20, 2017

Contributor

Can this be closed?

Contributor

mattias-p commented Dec 20, 2017

Can this be closed?

@sandoche2k

This comment has been minimized.

Show comment
Hide comment
@sandoche2k

sandoche2k Dec 20, 2017

sandoche2k commented Dec 20, 2017

@mattias-p mattias-p closed this Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment