Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Module::Install #53

Closed
mattias-p opened this issue Apr 24, 2018 · 1 comment
Closed

Remove Module::Install #53

mattias-p opened this issue Apr 24, 2018 · 1 comment

Comments

@mattias-p
Copy link
Member

mattias-p commented Apr 24, 2018

Should inc::Module::Install be removed from the source repo and dealt with as a dependency instead? The idiomatic way seems to be using configure_requires declarations in Makefile.PL and including META.yml in the source repo.

Pros:

  • We could remove the step to create inc/.author for Zonemaster::LDNS in the ReleaseProcess.
  • We don't have to maintain inc::Module::Install in the source repo.

Cons:

  • We'd have to add a step to make sure META.yml is up to date for Zonemaster::LDNS in the ReleaseProcess.
  • We require Module::Install 1.19 but CentOS only provides 1.06.
@sandoche2k
Copy link

@mattias-p close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants