Fix classifier mount #3544

Merged
merged 4 commits into from Mar 6, 2017

Conversation

Projects
None yet
3 participants
@eatyourgreens
Member

eatyourgreens commented Mar 6, 2017

Fixes #3543 .

Describe your changes.
Mounts the Classifier once, then reacts to subject and classification changes when props change.

There could be components that relied on the old behaviour, so there may still be component code, dotted through the classifier components, that needs to be changed to run on componentWillReceiveProps or componentDidUpdate as well as on componentWillMount or componentDidMount.

Review Checklist

Optional

  • If it's a new component, is it in ES6? Is it clear of warnings from ESLint?
  • Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
  • If changes are made to the classifier, does the dev classifier still work?
  • Have you added in flow type annotations?
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 6, 2017

@eatyourgreens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @srallen, @simensta and @amyrebecca to be potential reviewers.

@eatyourgreens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @srallen, @simensta and @amyrebecca to be potential reviewers.

@eatyourgreens

This comment has been minimized.

Show comment
Hide comment
@eatyourgreens

eatyourgreens Mar 6, 2017

Member

Playing around with I Fancy Cats, I'm not 100% sure that I've got the subject seen status right for new subjects.

Member

eatyourgreens commented Mar 6, 2017

Playing around with I Fancy Cats, I'm not 100% sure that I've got the subject seen status right for new subjects.

@amyrebecca amyrebecca self-requested a review Mar 6, 2017

@amyrebecca

LGTM

@amyrebecca amyrebecca merged commit 104968b into master Mar 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@srallen srallen referenced this pull request Mar 6, 2017

Merged

Extract Task component #3522

1 of 9 tasks complete

@adammcmaster adammcmaster deleted the fix-classifier-mount branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment