Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Optimize all workflows request #3556
Builds on #3545. This refactors the workflow fetch to be in the project page controller component. I still need to do some work on it, but wanted some initial thoughts. I wanted to eliminate as much as possible fetching for all active workflows that has an arbitrary page size number. For getting a random workflow, I've decided to just pick out of the
There's more work to do with reworking the request for preferences and the listener for it as well as moving the actual workflow request into the classifier, but those should be separate branches to stay in scope here.
For the testing, I'm having difficulty with figuring out good tests and API mocking, so I'd like to do that separately too. I don't think I'm breaking anything with the changes in this as is, but we'll find out quickly once merged like with the task rewrite.
This was referenced
Mar 13, 2017
@eatyourgreens that bug should be fixed now. The preferences handling needs a lot of work and some thought and this is partially related to unexpected behavior from the API client's handling of resource caching.
Basically what's happening is this:
Instead what is happening is that it still has the
So the preferences still have a
Looks good to me. One small change where I think you've missed a change from props to state.
Personally, I still find all the