New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Markdown for talk status #4711

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@eatyourgreens
Member

eatyourgreens commented Jun 21, 2018

Replace HTML with Markdown in talk status template strings on the project home page. Any markup in project titles, or the number of active users, is now rendered as plain strings rather than parsed as HTML.

Staging branch URL: https://talk-status.pfe-preview.zooniverse.org/projects/martenveldthuis/-svg-onload-equals-confirm-xss?env=production

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

Use Markdown for talk status
Replace HTML with Markdown in talk status template strings on the project home page. Any markup in project titles, or the number of active users, is now rendered as plain strings rather than parsed as HTML.
@camallen

LGTM - :shipit:

@eatyourgreens eatyourgreens merged commit 807d2dd into master Jun 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eatyourgreens eatyourgreens deleted the talk-status branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment