Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication documentation #3051

Merged
merged 8 commits into from Jan 29, 2019

Conversation

@marten
Copy link
Contributor

commented Jan 28, 2019

Rebase of #2994, with @camallen's great doc now integrated into the documentation website and @adammcmaster's comments resolved.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.
camallen and others added 7 commits Nov 7, 2018
client creds example with postman.
Co-Authored-By: camallen <campbell.allen@gmail.com>
Co-Authored-By: camallen <campbell.allen@gmail.com>
Co-Authored-By: camallen <campbell.allen@gmail.com>
add example on how to retrieve a token for client credentials in ruby
@marten marten requested a review from camallen Jan 28, 2019
Copy link
Member

left a comment

:shipit:

@marten marten merged commit 921b141 into master Jan 29, 2019
4 checks passed
4 checks passed
Hound No violations found. Woof!
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@marten marten deleted the update_docs branch Jan 29, 2019
@marten marten referenced this pull request Jan 29, 2019
0 of 4 tasks complete
zooniverse-jenkins added a commit that referenced this pull request Jan 29, 2019
generated from commit 921b141
@marten marten changed the title Update docs Authentication documentation Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.