-
Notifications
You must be signed in to change notification settings - Fork 2
British Science Week 2017 (temporary addition) #98
Conversation
PR UPDATE: WELL FUUUCCC-
Workaround?
This is obviously sub-optimal, but it's a solution given the constraints that we're facing. I'm keen to hear thoughts on this. |
zooniverse/haw#9 might work. I'm not sure how to test it. |
Nice work on the banner by the way 👍 |
70d543d should fix the haw build errors (fingers crossed.) |
Thanks @eatyourgreens ! I have an idea for testing zooniverse/haw#9 and solving the issue for Penguin Watch:
In short, the updated haw looks great! EDIT: Just saw your use |
If that works then I'll merge zooniverse/zooniverse-readymade#40 and publish a new version. |
@eatyourgreens aaawww yeah, it works. 👍 To confirm:
This is looking good! I'm confident enough now to do a production deploy for Penguin Watch. I'll follow up with you shortly about what needs to be done to correctly propagate the haw/zooniverse-readymade update across other affected repos. |
@shaunanoordin published as |
Thank you so much @shunanoordin and @eatyourgreens!
…On 7 March 2017 at 12:39, eatyourgreens ***@***.***> wrote:
@shaunanoordin <https://github.com/shaunanoordin> published as
zooniverse-readymade 1.5.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFEyd5tllh1oexx7B_PuSJ21GQr6CV2Hks5rjVAUgaJpZM4MUfpO>
.
|
I've just updated master to add German translations, so this will need rebasing. |
Woop! Thank you both!
Dr Tom Hart, Penguinologist.
Department of Zoology,
South Parks Road,
Oxford,
OX1 3PS.
+44 1865 600 170
www.penguinwatch.org<http://www.penguinwatch.org/>
www.penguinlifelines.org<http://www.penguinlifelines.org/>
From: Shaun A. Noordin [mailto:notifications@github.com]
Sent: 07 March 2017 12:35
To: zooniverse/penguinwatch
Cc: Subscribed
Subject: Re: [zooniverse/penguinwatch] British Science Week 2017 (temporary addition) (#98)
@eatyourgreens<https://github.com/eatyourgreens> aaawww yeah, it works. 👍
To confirm:
1. I've deleted node_modules and reinstalled via npm install (package.json is using zooniverse/zooniverse-readymade#upgrade-haw)
2. I ran npm run build and npm run beta; both are functioning correctly.
This is looking good! I'm confident enough now to do a production deploy for Penguin Watch. I'll follow up with you shortly about what needs to be done to correctly propagate the haw/zooniverse-readymade update across other affected repos.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#98 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHUobw1wlDvCeXm4pOPrCgS40rCNoK9Yks5rjU7egaJpZM4MUfpO>.
|
70d543d
to
7d252ba
Compare
GitHub Code Note: In case any fellow dev in the year 3010 is trying to follow what happened in this convo, note that this branch was rebased onto a new master that incorporates PR #99 The root of the problem was that the previous master was using Also, fellow dev of the year 3010: say hi to our robot overlords for me! Please tell them |
7d252ba
to
931baef
Compare
This has been rebased again to accommodate some text changes in #100 |
@mrniaboc https://www.penguinwatch.org/ has been updated with the new link! Your code update was good, by the way; it's just that instead of merging to master, we'd just |
Thanks @shaunanoordin!
…On 10 March 2017 at 12:27, Shaun A. Noordin ***@***.***> wrote:
@mrniaboc <https://github.com/mrniaboc> https://www.penguinwatch.org/ has
been updated with the new link! Your code update was good, by the way; it's
just that instead of merging to master, we'd just npm run deploy in this
case. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFEyd6orSXMtSyCnZltBYcwUqg_D2CPZks5rkUGvgaJpZM4MUfpO>
.
|
84af978
to
be06384
Compare
Rebased again to reflect new information for schools, as added in #101 Wait, that PR was one hundred and one? Damn, should have named it Education 101 |
be06384
to
2e75ab5
Compare
PR Update: Closing TimeFiona just gave the clear to remove these temporary additions to Penguin Watch. As of right now, https://www.penguinwatch.org/ has been reverted back to its original non-BSW incarnation. This PR will be closed, but hopefully preserved in case similar temporary modifications are required in the future. |
PR Overview
master
branch will be manually re-deployed.Notes
penguinwatch
->zooniverse-readymade
->haw
->image-min
)npm install
, thoughhaw
issue.