Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox.ini and configure TravisCI + Coveralls. #4

Merged
merged 4 commits into from
Mar 21, 2018
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Feb 28, 2018

The versions are pinned for Zope 2.13, to get a baseline of working tests.

(I could not yet figure out why the tests fail.)

@mauritsvanrees
Copy link
Member

Looks okay, except of course that some tests give errors.

On Plone 5.1, with Zope 2.13, we use CMFUid branch 2.2.
On Plone 5.2, with Zope 4, we use CMFUid branch master.
On both coredev branches, the CMFUid tests pass.
The master branch has fixes for compatibility with Zope 4, so you may need to change the pinnings to use that.

@icemac
Copy link
Member Author

icemac commented Mar 6, 2018

@mauritsvanrees Thank you for looking into this, so the master of this package should run on Zope 4 but I forced it to run with Zope 2.13. Maybe this is the reason of the errors.

Michael Howitz added 3 commits March 16, 2018 09:22
The versions are pinned for Zope 2.13, to get a baseline of working tests.

(I could not yet figure out why the tests fail.)
@icemac icemac merged commit c498cb6 into master Mar 21, 2018
@icemac icemac deleted the add-tox-and-travis branch March 21, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants