Python3 with application initialization - #4
Conversation
|
If fails on Python 2.7, but I am not sure why. |
150ae0d to
298e447
Compare
|
Thank you for this! Was wondering where session-init had gone. Didn't think far enough to realize the Application was missing during Product initialization (I just thought I didn't find it when I tried to fix the session initialization). |
|
The initialization of SessionDataManager in this product has a bad smell, but I don't see a way to handle this differently without a major API change. The order in which products are loaded is deterministic (at least), but it's dependent on the user configuration. As seen in OFS/Application.py:import_products, the order of products is by Products paths, and then by name within each path. So by that logic, Products.TemporaryFolder will usually load after Products.Sessions (except when users have TemporaryFolder in a filesystem path that is included before Sessions) I'll adapt the buildout.cfg so that the build is green and then would like to merge this. ACK? |
When splitting off this product from the main Zope repository, the Application initialization has been removed. This code brings back the automatically created temporary folder and Session Data Container.
d29e4b7 to
6cf7742
Compare
6cf7742 to
1a5fb74
Compare
|
Released to PyPI as https://pypi.org/project/Products.TemporaryFolder/5.1/ |
|
🍾 thanks |
This needs zopefoundation/Zope#277 and zopefoundation/Zope#281 to be merged in Zope