From 215f48f09ba6bd58cf1672c8561fc938bf5f443c Mon Sep 17 00:00:00 2001
From: Tim Peters <tim.one@comcast.net>
Date: Sun, 19 May 2002 17:04:42 +0000
Subject: [PATCH] Beef up the reindexing tests to check that they actually fail
 before the original doc text gets restored.

---
 tests/testZCTextIndex.py | 50 ++++++++++++++++++++++++++++++++++------
 1 file changed, 43 insertions(+), 7 deletions(-)

diff --git a/tests/testZCTextIndex.py b/tests/testZCTextIndex.py
index d79ba84..7a1e00b 100644
--- a/tests/testZCTextIndex.py
+++ b/tests/testZCTextIndex.py
@@ -212,12 +212,33 @@ def testRanking(self):
         self._ranking_idf()
         self._ranking_queries()
 
-        # A digression to exercise re-indexing.  This should leave
-        # things exactly as they were.
+        # A digression to exercise re-indexing.
         docs = self.docs
-        for variant in ("hot cold porridge python", "pease hot pithy ",
-                        docs[-1]):
+        for variant in "hot cold porridge python", "pease hot pithy":
             self.zc_index.index_object(len(docs), Indexable(variant))
+            try:
+                self._ranking_tf()
+            except (AssertionError, KeyError):
+                pass
+            else:
+                self.fail("expected _ranking_tf() to fail -- reindex")
+
+            try:
+                self._ranking_idf()
+            except (AssertionError, KeyError):
+                pass
+            else:
+                self.fail("expected _ranking_idf() to fail -- reindex")
+
+            try:
+                self._ranking_queries()
+            except AssertionError:
+                pass
+            else:
+                self.fail("expected _ranking_queries() to fail -- reindex")
+
+        # This should leave things exactly as they were.
+        self.zc_index.index_object(len(docs), Indexable(docs[-1]))
         self._ranking_tf()
         self._ranking_idf()
         self._ranking_queries()
@@ -292,9 +313,17 @@ def testAbsoluteScores(self):
 
         self._checkAbsoluteScores()
 
-        # Exercise re-indexing.  This should leave things exactly as they were.
-        for variant in "one xyz", "xyz two three", "abc def", docs[-1]:
+        # Exercise re-indexing.
+        for variant in "one xyz", "xyz two three", "abc def":
             self.zc_index.index_object(len(docs), Indexable(variant))
+            try:
+                self._checkRelativeScores()
+            except AssertionError:
+                pass
+            else:
+                self.fail("expected _checkAbsoluteScores() to fail -- reindex")
+        # This should leave things exactly as they were.
+        self.zc_index.index_object(len(docs), Indexable(docs[-1]))
         self._checkAbsoluteScores()
 
     def _checkAbsoluteScores(self):
@@ -346,8 +375,15 @@ def testRelativeScores(self):
             self.zc_index.index_object(i, Indexable(doc))
         self._checkRelativeScores()
 
-        # Exercise re-indexing.  This should leave things exactly as they were.
+        # Exercise re-indexing.
         self.zc_index.index_object(9, Indexable("two xyz"))
+        try:
+            self._checkRelativeScores()
+        except AssertionError:
+            pass
+        else:
+            self.fail("expected _checkRelativeScores() to fail after reindex")
+        # This should leave things exactly as they were.
         self.zc_index.index_object(9, Indexable(doc))
         self._checkRelativeScores()