Remove multi-threaded server mode #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 2016 this mode was opt-in for a long time with the default being single-threaded asyncio-based server implementation. We believe nobody actually used multi-threaded ZEO5 server mode for real at all. Multi-threaded server mode was deprecated this spring (#190), and later found to have concurrency bug that lead to data corruption (#209). Given deprecation status, instead of fixing those bugs let's finally remove the multi-threaded server mode.
|
/cc @d-maurer |
Pull Request Test Coverage Report for Build 2973579663
💛 - Coveralls |
dataflake
approved these changes
Sep 2, 2022
|
@dataflake, thanks for the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2016 this mode was opt-in for a long time with the default being
single-threaded asyncio-based server implementation. We believe nobody
actually used multi-threaded ZEO5 server mode for real at all.
Multi-threaded server mode was deprecated this spring
(#190), and later found to
have concurrency bug that lead to data corruption
(#209).
Given deprecation status, instead of fixing those bugs let's finally
remove the multi-threaded server mode.